Agustin Sanchez• 250
@AgusSaMac
Posted
Hello! Congratulations for finishing your challenge! Here's some feedback:
- The attribution should be moved at the end of the html just before the closing
</body>
tag, and change it to<footer>
. Atributions and legal disclaimers are usually part of the footer. - Try to always link the attribution to your profile. This is a good practice for the future, so potential employers and/or clients may have a way to contact you.
- Change the
<section>
tag for<main>
. - use a
<h1>
tag instead of<h4>
. - You have an html issue in the image source, change
\
for/
.
Now on the css part.
- You were going great when you applied the box sizing as border box, just add a box-sizing: inherit, check: https://www.paulirish.com/2012/box-sizing-border-box-ftw/.
- Also to the html tag add a
font-size: 62.5%
this is to make 1rem = 10px. - I would recommend against using static units like px, cm and such, because screen sizes vary continously, if you leave them static, it may cause problems with some screens.
I hope it helps.
Happy coding!
Have a great day!
Marked as helpful
0