@Mr-Funderburk
Posted
Good attempt! I see just a couple of things that need to be addressed.
First, and most importantly, your QR code image is broken. This is being caused by your src attribute having a forward slash at the beginning of the URL on line 36:
<img src="/images/image-qr-code.png" alt="QR code">
Removing the first forward slash like this should get the image back.
<img src="images/image-qr-code.png" alt="QR code">
With this layout, I don't think you need the media query. It was designed to be the size of a mobile from the beginning. By using the query in the way you have it causes unintended effects when viewed full screen.
I like your use of CSS variables to keep your code clean and easier to update!
Marked as helpful
@LuisGonzH94
Posted
@Mr-Funderburk Thank you very much for the feedback.
With these fixes, do I have to resubmit it on the frontend mentor website as a new solution, or will this not be necessary as this will be a learning experience?
as for the media query, I was hesitating whether to implement it or not. It is now clear that I didn't need it.
Again, I sincerely appreciate your comments.
@Mr-Funderburk
Posted
@LuisGonzH94 For the experience, I would update your code and re-up it to GitHub. I don't believe you have to resubmit here or anything. There is a button to create a new screenshot, I would do that so you have the QR code in there.
Just remember this is a place of challenge and learning. So ultimately it's what you get out of it that's important. Keep up the good work and looking forward to seeing more of your posts!
Marked as helpful
@LuisGonzH94
Posted
Made the proper modifications thanks to you @Mr-Funderburk ! My solution might not look as center as the design, but I'm okay with my progress on this challenge.
Up to the next one now 😁.
