Qrcode component, done by using vanilla CSS and html, implemented flex

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Williams, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • remove all margin from .showcase class because with flex they are superfluous
  • add align-items: center to body for align the card horizontally
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  0
• 

  J J Williams•350

  @WilledwestPosted almost 2 years ago

  Thank you very much Deniel, I really appreciate this ED-Infos.

  0