Qr_code component challenge using custom css
Design comparison
Solution retrospective
Did i replicate the design well?
Community feedback
- @TRIPLE-ADEPosted over 2 years ago
Hello @omoloye, Good Job the design looks nice. Anyway, I think there are some aspects that you can improve on .
to make your main section appear in middle
body{ display : flex; flex-direction : column; justify-content : center; align-item : center;} and also add a min-height : 100 vh; to the body section, that will make the body section to appear in full pageI hope this feedback would be useful)
Marked as helpful0 - @tjewliusPosted over 2 years ago
hello Omoloye,
The design does look nice but I was suggesting to improve on;
-
You had used the div to contain the page content, if you could change to <main> so as to solve the accessibility issues.
-
Vertically align your content so it's in the center of the page.
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord