QR-code component by using HTML & CSS

Community feedback

• 

  M.SADHASIVAM•10

  @sadhapPosted about 2 years ago

  thank you so much !

  0
• 

  Jesse Good•120

  @jessegoodPosted about 2 years ago

  Here are a few points I saw. Hopefully this helps.

  (1) Looks like you mispelled card-img-containere which is causing some of the styles not to work.

  (2) I would recommend not wrapping everything in a div and it will cut down on how much styling you have to use.

  (3) The other comment already addressed it, but using a main landmark for accessibility is also a plus.

  0
• 

  romila•3,570

  @romila2003Posted about 2 years ago

  Hi @sadhap,

  Welcome to the frontend mentor community and congratulations for 🎉 for completing your first challenge, the card looks great. There are some issues I want to address:

  1. It is best practice to wrap the main content within the main tag which would ensure that your content is wrapped within the correct landmarks e.g. <main class="container"></main>
  2. The img should have a border-radius.
  3. You can set the font-size for the h1 tag to be bigger
  4. Instead of using the margin property to center the card, you can use the flex property instead e.g.

  body {
    display: flex;
    align-items: center;
    justify-content: center;
    min-height: 100vh;
  }
  

  Overall, great attempt and wish you the best for your future projects so keep coding 👍.

  0

  ---

  

  M.SADHASIVAM•10

  @sadhapPosted about 2 years ago

  @romila2003 thank you so much dear ! :)

  1