QR-code component by CSS

Community feedback

• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi @mahnegarr,

  Congrats on completing the challenge

  You did good, to add border radius you need to remove the padding you have on the image once you remove the padding the image will be misaligned you can add the following to fix that.

  main.card {
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
  }
  

  Hope this is helpful

  Marked as helpful

  1
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi @mahnegarr, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

  1.To add border radius to the image just add:

  img {
      width: 260px;
      padding: 20px 20px 10px;
      border-radius: 15%;
  }
  

  2.Replace the <h2> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in level of importance, never jump a level.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0