QR-code component

Community feedback

• Account deleted

  Hey Oleg, congratulations on completing the challenge! You did a good job 😉

  Let me give you some little tips for optimizing your code:

  • use article tag for the card container instead of div for improve the Accessibility
  • centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • set width: 20rem to component class and width: 100% to img element
  • use flexbox to the body to center the card. Read here -> flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😁 by Travolgi

  Marked as helpful

  1