QR-Code Component

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 10 months ago

  Hello @hassanmoaa!

  Your solution looks great!

  I have a couple of suggestions for improvement:

  • First: In order to make your HTML code more semantic, use <h1> for the main title instead of <h3>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  • Second: Still about semantic HTML, replace div.card with main.card.

  All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  1
• 

  Dongmo Shu•280

  @dongmo-shuPosted 10 months ago

  Hello @hassanmoaa

  Congratulations on completing the challenge! You did a good job.

  Here is my take on improving your code. Improve your front-end skills by building projects elements in your code are not styled in the right colour. hsl(218, 44%, 22%) is the right colour

  I hope this was helpful

  Marked as helpful

  1