Qr-code component

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The Alt Tag description for the QR image needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

  • Change width to max-width in your component’s container to make it responsive. You will also want to remove the height as it is unnecessary.

  • Change width to max-width: 100% in your image to make it responsive. You will also want to remove the height as it is unnecessary.

  • A media query is not needed for this challenge. Using responsive properties will do in making your content responsive.

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  Marked as helpful

  0

  ---

  

  Syed Umair•180

  @SYEDUMAIR007Posted about 2 years ago

  @vcarames Thank you for your valuable feedback, and yes, I will do as you said.

  0
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @SYEDUMAIR007 👋, good job on completing this challenge, and welcome to the Frontend Mentor Community! 🎉

  I have some suggestions you might consider to improve your code:

  • Use the <main> tag to wrap all the main content in your solution rather than <container class="main">.
  • In HTML there is no <container> tag.
  • Use <footer> instead of <div class="attribution">. The <footer> element contains authorship information.
  • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
  • To make alternative texts more useful, add descriptive text to the alt attribute of the QR image to explain what the QR image does.

  I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  Marked as helpful

  0

  ---

  

  Syed Umair•180

  @SYEDUMAIR007Posted about 2 years ago

  @MelvinAguilar Thank you for your suggestion, i am going to improve my code right now

  1

  

  Syed Umair•180

  @SYEDUMAIR007Posted about 2 years ago

  @SYEDUMAIR007 hey improved my code as per your suggestions, check out and comment

  0