QR-Code Component

Community feedback

• 

  Grego•1,310

  @Grego14Posted 7 months ago

  Hello! 🎉 congratulations on completing the challenge! 🎉

  Remember to specify a more descriptive alt attribute, since it is used by screen readers.

  Do not skip the headings, first you must use h1 not h2.

  Do not use the br tag, as it is considered bad practice, and on some screens it makes the text look bad.

  To avoid applying the font-family all the time, you can directly add it to its parent element, such as the body, and many of its child elements will inherit that style.

  I hope this helps! 😁

  Marked as helpful

  1

  ---

  

  Paulkendrick2126•70

  @Paulkendrick2126Posted 7 months ago

  Thanks a lot@Grego14. Great insights. These are really helpful tips, especially moving forward.

  I would love you to expound on not using the "br" tag if you don't mind sharing your discord username or social media handle you're most active on so we can correspond

  0

  

  Grego•1,310

  @Grego14Posted 7 months ago

  @Paulkendrick2126 There are many opinions on whether or not to use the br tag to create line breaks.

  But it should only be used when it is necessary to break the text, such as a poem of a few words per verse. As it can cause accessibility problems

  If you want to know more 👉 Br Tag

  I don't use social media so I couldn't give you any, but if you want to continue talking about this topic you can reply to this message, until a few days ago I was very active on this page but I've been doing a challenge and it's been hard for me because I've had to learn some things I didn't know to be able to continue it.

  0

  

  Paulkendrick2126•70

  @Paulkendrick2126Posted 7 months ago

  Oh, great @Grego14. Thanks for the tip. I'll check the article out, and also, should I have a project I wouldn't mind you reviewing, I'll send it here so you can send a message on Git Hub.

  I'm also not big on social media but in this age of tech jobs layoffs i use it for news and also just try to leverage it in some ways. Thanks once again.

  0
• 

  Abdellah Abadou•270

  @abdellah-abadouPosted 7 months ago

  Instead of using :

  margin: 0 auto;

  you should have used (in main container) :

  display: flex;

  align-item: center;

  1

  ---

  

  Paulkendrick2126•70

  @Paulkendrick2126Posted 7 months ago

  Thanks @abdellah-abadou. This would in my understanding of flexbox. I would love to connect with you and perhaps get some correction and tips from you .

  Is there a social media platform you're most active on

  0