QR-Code Component

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 10 months ago

  Hello @ZMBAIG 🙋🏽‍♂️

  Your solution looks excellent!

  I have a suggestion about your code that might interest you:

  📌 If you don't have the Figma design files, I recommend using a browser extension called Perfect Pixel.

  It allows you to compare your finished project with the design images that come along when you download the project and check the (almost exact) dimensions. It's very useful!

  I hope it helps you in future projects! 😊

  Other than that, great job!

  0
• 

  Amer•360

  @amerrikaPosted 10 months ago

  Hi ZM. Baig, I think you did a great job with the styling. My advice would be to not to make the qr-component using the main-element but to make it with a article-element or a div-element that would be placed inside the main-element. And, instead of section-element for heading and paragraph I think a better solution would be to use a div-element. Something like this:

  <main>
      <article class="scan-container">
          <img>
          <div>
              <h1></h1>
              <p></p>
          </div>
      </article>
  </main>
  

  This way the code is more semantic.

  Other than that, a great job.

  Good luck with coding!

  0