Qr-code challange

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @Wonski312 👋, good job for completing this challenge!

  Here are some suggestions you might consider:

  • Try to fix the issues indicated by the report in this solution.

  To make the card a bit responsive:

  • Use min-height: 100vh to body instead of height, with this property you let the body element grow even more if necessary.
  • Use margin: 0.938rem or margin: 15px in the .qr-card selector so that it has some space when viewed on mobile devices.
  • Use max-width: 375px to .qr-card selector instead of width, also remove min-width: 375px; and width: 375px; this will make the card container a bit responsive on mobile, but no larger than 375px

  I hope those tips will help you.

  Good Job and happy coding !

  Marked as helpful

  2
• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  Hello, there! 👋

  Congratulations on completing this challenge! 🎉

  Here are some suggestions for improvements.

  • I recommend setting the box-sizing: border-box to all elements. You can use universal selector (*) to select all elements. Setting box-sizing: border-box on the body element won't make all elements to be box-sizing: border-box.
  • Defining font sizes in px is not accessible, because the user cannot change the font size in some browsers. For example, users with limited vision may wish to set the font size much larger than the size chosen by a web designer. Avoid using them for font sizes if you wish to create an inclusive design. (Reference: MDN documentation of font-size).

  I hope this helps! Happy coding!

  Marked as helpful

  1