Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-code card using CSS

David Oluremiβ€’ 100

@VectorGits

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

RabicaTahirβ€’ 500

@RabicaTahir

Posted

Hi πŸ‘‹ David Oluremi. Congratulations on completing the challenge !

I have some suggestions about your code.

HTML⚑:

β–ͺ It is advisable that you place all your main site content in a landmark element <main>.

β–ͺ Best practice is to ensure that the beginning of a page's main content starts with a h1 element.

CSS 🎨:

β–ͺ Instead of using pixels in font-size, using relative units like em or rem is a good practice.

I hope you find it useful! By the way, the solution was great. πŸ™ŒπŸ’―

Enjoy coding, Stay Safe!🀞

Marked as helpful

1

David Oluremiβ€’ 100

@VectorGits

Posted

@RabicaTahir Thanks for the review on it, when you said the landmark element should be <main> did you mean -main |-index.html |-styles.css

1
RabicaTahirβ€’ 500

@RabicaTahir

Posted

@VectorGits put index.html code in the mian tag for removing error.

0
Francisco Carrilloβ€’ 5,540

@frank-itachi

Posted

Hello there πŸ‘‹. You did a good job!

I have some suggestions about your code that might interest you.

CSS 🎨:

  • You can use grid or flexbox to center the content no matter the viewport size. Using Grid:
body {
	min-height: 100vh;
        display: grid;
	place-content : center;
}

FlexBox

body {
	min-height: 100vh;
        display: flex;
	align-items: center;
	justify-content: center;
}

I hope you find it useful! πŸ˜„ Above all, the solution you submitted is great!

Happy <coding /> 😎!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord