QR-code card using CSS

Community feedback

• 

  RabicaTahir•500

  @RabicaTahirPosted over 1 year ago

  Hi 👋 David Oluremi. Congratulations on completing the challenge !

  I have some suggestions about your code.

  HTML⚡:

  ▪ It is advisable that you place all your main site content in a landmark element <main>.

  ▪ Best practice is to ensure that the beginning of a page's main content starts with a h1 element.

  CSS 🎨:

  ▪ Instead of using pixels in font-size, using relative units like em or rem is a good practice.

  I hope you find it useful! By the way, the solution was great. 🙌💯

  Enjoy coding, Stay Safe!🤞

  Marked as helpful

  1

  ---

  

  David Oluremi•100

  @VectorGitsPosted over 1 year ago

  @RabicaTahir Thanks for the review on it, when you said the landmark element should be <main> did you mean -main |-index.html |-styles.css

  1

  

  RabicaTahir•500

  @RabicaTahirPosted over 1 year ago

  @VectorGits put index.html code in the mian tag for removing error.

  0
• 

  Francisco Carrillo•5,540

  @frank-itachiPosted over 1 year ago

  Hello there 👋. You did a good job!

  I have some suggestions about your code that might interest you.

  CSS 🎨:

  • You can use grid or flexbox to center the content no matter the viewport size. Using Grid:

  body {
  	min-height: 100vh;
          display: grid;
  	place-content : center;
  }
  

  FlexBox

  body {
  	min-height: 100vh;
          display: flex;
  	align-items: center;
  	justify-content: center;
  }
  

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy <coding /> 😎!

  1