QR-code card solutions using css flex and css grid

Community feedback

• 

  Francisco Carrillo•5,540

  @frank-itachiPosted almost 2 years ago

  Hello there 👋. You did a good job!

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.
  • If your code has different sections that have a specific like a navigation, article, sections or footer, it’s a good practice to enclose those parts with HTML5 landmarks. For example, you could use a <footer> tag to wrap a footer section.
  • The heading order is important in the html structure so try to always start your headings with an <h1> tag and then you can decrease by one if you need to use more heading in your html code.

  CSS 🎨:

  • Avoid using absolute length units px, especially for font-size and width properties, because they are not relative to anything else so that means they will always be the same size. Instead, you can use relative lengths like em or rem. The benefit of that last one is element which has that unit will scale relatively to everything else within the page, e.g., the parent container. You can dig up about it here

  I hope you find it useful! 😁😁 Above all, the solution you submitted is great👌!

  Happy <coding /> 😎!

  Marked as helpful

  0
• 

  Josh•1,110

  @josh76543210Posted almost 2 years ago

  Great job on your solution! Looks Good!

  Here are some recommendations for improving your code:

  HTML: Use semantic elements such as <main> and <footer> to improve the accessibility and organization of your page.

  Alt text: Images must have alternate text. For example: <img src="images/image-qr-code.png" alt="QR code to frontendmentor.io"/>

  CSS: Use relative units like em or rem for the font-size instead of using pixels. The font-size in absolute units like pixels does not scale with the user's browser settings.

  I hope you find these useful!

  Happy coding!

  Marked as helpful

  0