Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-Code card

fd-pixel 10

@fd-pixel

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@MelvinAguilar

Posted

Hi @fd-pixel 👋, good job for completing this challenge and welcome to the Frontend Mentor Community! 🎉

Here are some suggestions to improve your code:

Try to fix the issues indicated by the report in this solution.

Tips:

  • Use min-height: 100vh to body to center the card
  • Add max-width: 372px; to the card selector and remove margin-top: 6rem;

You could use a CSS Reset to remove browser built-in styles and reduce browser inconsistencies

Your body's default margin causes the vertical scrollbar to appear

And add this:

* {
   box-sizing: border-box;
}

Popular reset style sheets:

Don't use <br> tag, the <br> tag is not semantic. It should never be used to add vertical spacing, it is only used in specific cases (e.g. poem or an address) also when a screen-reader reads the text it will break the text at the <br /> tag and break the flow of reading, You could use padding or margin styling via CSS to avoid them. More Information here.

For example : Use margin: 0 3rem; in the .second-text selector to get the same result without using the <br> tag.

I hope those tips will help you.

Good Job and happy coding !

Marked as helpful

0

fd-pixel 10

@fd-pixel

Posted

@MelvinAguilar Thank you for your helpful info.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord