@MelvinAguilar
Posted
Hi @fd-pixel 👋, good job for completing this challenge and welcome to the Frontend Mentor Community! 🎉
Here are some suggestions to improve your code:
Try to fix the issues indicated by the report in this solution.
Tips:
- Use
min-height: 100vh
tobody
to center the card - Add
max-width: 372px;
to the card selector and removemargin-top: 6rem;
You could use a CSS Reset to remove browser built-in styles and reduce browser inconsistencies
Your body's default margin causes the vertical scrollbar to appear
And add this:
* {
box-sizing: border-box;
}
Popular reset style sheets:
Don't use <br>
tag, the <br>
tag is not semantic. It should never be used to add vertical spacing, it is only used in specific cases (e.g. poem or an address) also when a screen-reader reads the text it will break the text at the <br />
tag and break the flow of reading, You could use padding or margin styling via CSS to avoid them. More Information here.
For example : Use margin: 0 3rem;
in the .second-text selector to get the same result without using the <br> tag.
I hope those tips will help you.
Good Job and happy coding !
Marked as helpful
@fd-pixel
Posted
@MelvinAguilar Thank you for your helpful info.