Submitted about 1 year ago

QR-code adjusted for mobile and desktop

01JohnnyJohn• 30

@01JohnnyJohn

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

Definitely need to get more practice of "coding flow". I mean I have to understand better how to code adherently, logically, methodically instead of coding jumping from one part of the project to another, making some small changes here and there.

Also, I would like to get some hint or help with getting rid of extra empty space below my text elements when screen size is 800px+ - once I set the screen size (in Chrome DevTools) to 800px empty space appears below my heading and paragraph

Community feedback

Tushar Biswas• 4,080

@itush

Posted about 1 year ago

Congratulations on completing the challenge! 🎉

Welcome to the platform! 🎉 We're thrilled to have you here and excited to see your progress 💪as you continue your front-end development journey.

If you remove height: 75%; from .main-grid and padding: 2rem 0; it might look better.

In my projects:

I always start with mobile-first workflow.
I use at least one main element for a page (entire content goes into the main, if I'm not using header & footer), and avoid divs as much as possible and use section and article element wherever I can.

<body>
<main>
All content 
</main>
</body>

I Use relative units as much as possible and avoid absolute units whenever possible.
If you are someone who is just starting out with front-end development, I strongly suggest starting with the QR code component project(which you did). Also in the challenges page you may filter by (Newbie, HTML&CSS) sort by (easier first) to select projects that will help you solidify your foundation. To avoid any potential knowledge gap⚠️ please first solidify HTML, CSS, JS fundamentals and then move on to any framework or library.
I remember when I started out, I made countless mistakes and spent long hours searching for solutions. But hey, you don't need to go through the same struggles! 🙌 To help you shorten the learning curve, I recommend going through the following articles. They contain valuable insights that can make your journey smoother:

📚🔍 12 important CSS topics where I discuss about css position, z-index, box-model, flexbox, grid, media queries, mobile-first workflow, best practices etc. in a simple way.

📚🔍 11 important HTML topics where I discuss about my thought process and approach to convert a design/mock-up to HTML along with important topics like block and inline elements, HTML Semantic Elements.

I hope you find these resources helpful in your coding adventures! 🤞

I'm eagerly looking forward to seeing the amazing projects you'll create in the future! 🚀💻

Keep up the fantastic work and happy hacking! 💪✨

Marked as helpful

Lucas Exequiel• 200

@arrejoria

Posted about 1 year ago

Hey, good job on this solution! 💯 I would like to help you with some tips or points that I noticed in your work.

I have identified a few areas where I think you can improve your design:

1. [CSS]: For this layout, the responsive view wasn't too important, but it looks bad if the container uses the entire viewport on other devices. The layout "container" has an explicit unit, try using a "max width" for your content instead of width: 23.5% and center the width of the flexbox container and some padding.

Here are some recommendations that I found useful for improving your design and skills:

1. [HTML]: Try to structure your HTML and class selectors in boxes. It has a parent element that has content and uses the body as a container.

2. [CSS]: Try using libraries like Bootstrap or CSS processors like SASS/Less to explore a bit more with CSS

3. [CSS Unit]: Try not to use % for your content or containers, rather use the height and width of the viewport with max and min properties. Explore further using margin or padding to get the result you want.

Thanks for sharing and I hope some of the above was helpful to you! keep it up you are doing great! 🧉

Lucas,

Marked as helpful

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord