Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qrcode

madyβ€’ 40

@sloths8

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

rayaβ€’ 2,850

@rayaatta

Posted

Hi πŸ‘‹sloths8, Congratulations on completing this challenge πŸŽ‰.

I have some suggestions you might find useful.

1 Try to make your html more Semantic by wrapping the main page content inside a <main> tag . Replace <div class="box1"> With <main class="box1">. This changes nothing visually but Using it makes all the difference. Using semantic markup improves

SEO

And

accessibility

You can find out more about the main tag in this article πŸ“°.

2 I noticed that you used h4 .since it is the only heading in the document you should replace it with <h1 class="heading">.

Here's a quick guide on how to use them:

The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on. You can then style them in you css.

Unlike what most people think, it's not just about the size and weight of the text It is about maintaining a clear and consistent hierarchy through out the document

I hope this helps πŸ™ƒ

Happy coding ✌️

Marked as helpful

0

madyβ€’ 40

@sloths8

Posted

thank u so much raya for your recommendations i'll follow what you said in next projects @rayaatta

1
madyβ€’ 40

@sloths8

Posted

amazing

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord