Qrcode

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 9 months ago

  Hello @LukebaKueno!

  Your solution looks great!

  I have a couple of suggestions (about semantic HTML) for improvement:

  📌 First: Use <main> to wrap the main content instead of <div>.

  Think of <div> and <span> in HTML like plain boxes or placeholders. They're handy for holding content, but they don't tell us anything about what's inside or what it's meant for on the webpage.

  📌 Second: Use <h1> for the main title instead of <h2>.

  Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> defines the most important heading.
  • <h6> defines the least important heading.
  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  1

  ---

  

  Lukeba•60

  @LukebaKuenoPosted 9 months ago

  @danielmrz-dev Thank you very much for your opinion, it was very useful. I hope to count on your opinions in my next challenges

  1
• 

  Abere Fejiro•490

  @Fejiro001Posted 9 months ago

  Hi there good job with the solution. Some things I will point out:

  • Because you gave the card a fixed height height: 70%, the text is overflowing. so just put height: auto;
  • Also for accessibility, it would be better use semantic html rather than div for the card. For the card you can use section or give the div an ARIA role like contentinfo

  Marked as helpful

  1

  ---

  

  Lukeba•60

  @LukebaKuenoPosted 9 months ago

  @Fejiro001 Thank you very much for your opinion, it was very useful. I hope to count on your opinions in my next challenges.

  1

  

  Lukeba•60

  @LukebaKuenoPosted 9 months ago

  It worked perfectly, thanks again, I updated the code

  @Fejiro001

  1

  

  Abere Fejiro•490

  @Fejiro001Posted 9 months ago

  @LukebaKueno I'll be on the lookout

  0

  

  Abere Fejiro•490

  @Fejiro001Posted 9 months ago

  @LukebaKueno That's great

  0