qr-code

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 9 months ago

  Hello @austin11183!

  Your solution looks great!

  I have a couple of suggestions (about semantic HTML) for improvement:

  📌 First: Use <main> to wrap the main content instead of <div>.

  Think of <div> and <span> in HTML like plain boxes or placeholders. They're handy for holding content, but they don't tell us anything about what's inside or what it's meant for on the webpage.

  📌 Second: Use <h1> for the main title instead of <div>.

  Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> defines the most important heading.
  • <h6> defines the least important heading.
  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  0
• 

  Osman Bay•690

  @osmanbay90Posted 9 months ago

  Great job on completing the Frontend Mentor challenge! Your project shows promise, but here are some areas where you could make improvements in your HTML and CSS:

  Mistakes:

  Missing closing tag for meta viewport: You need to close the meta viewport tag properly with >.

  Relative path for image source: Make sure the path to the image is correct. If the image is not loading, ensure that the path ./images/image-qr-code.png is correct relative to the HTML file.

  Incomplete CSS class names: Avoid using abbreviated class names like png_class. Use more descriptive names that indicate the purpose of the class.

  Hardcoded width and height for card: Using fixed width and heightmay not be responsive. Consider usingrelative unitslikepercentageorviewport units`.

  Unnecessary styles: Some styles may not be needed or could be simplified.

  Improvements:

  Use of semantic HTML elements: Consider using semantic HTML elements like <header>, <main>, <section>, <article>, and <footer> for better structure and accessibility.

  Responsive design: Ensure your design looks good on various screen sizes. You can achieve this by using relative units and media queries.

  Consistent naming convention: Maintain a consistent naming convention for classes and IDsThis improves code readability and maintainability.

  Optimize image: Optimize your image to reduce its size without losing quality. This can improve page load speed.

  Accessibility: Ensure your website is accessible to users with disabilities by using appropriate HTML elements and attributes.

  Remember, practice makes perfect! Keep refining your skills by tackling more challenges on Frontend Mentor. Happy coding! 🚀

  0