Saulius K.• 560
@TH3RIV
Posted
Hi, @ahmedd-osama!
Your work looks great, but I have a few suggestions to make it even better:
- Your page should contain landmarks, so it makes your code easier to read on what content is what and also helps screen-readers to figure out what is what. In this case your card should be wrapped withing
main
tags and your attribution should be wrapped withinfooter
tags. - Try to avoid using
px
values as much as possible and userem
instead. - Try to start using "custom CSS properties". While this is not essential in this project, it is a good habit to develop.
Hope this helps!
Marked as helpful
1
Ahmed Osama• 80
@ahmedd-osama
Posted
@TH3RIV Thanks a lot. I will start to look out for those details next time.
0