QRcode

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello 👋. Congratulation on successfully completing your first challenge 🎉 ! !

  I have some recommendations regarding your code that I believe will be of great interest to you.

  Background 🌆:

  • You should not recreate the background, you used the image desktop-preview.jpg to create your solution, but that image is for decoration and is a nice way to present the challenge, for example, you can use it in your github README.

    You must use the images desktop-design.jpg and mobile-design.jpg to create your solution.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.

  • Always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy. Source 📘

  Alt text 📷:

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  CSS 🎨:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. You can read more about this here 📘.

  • To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📘.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Nevin Siby•50

  @Nevin-SibyPosted almost 2 years ago

  @MelvinAguilar Thanks for the feedback Melvin. I will implement your suggestions in my code. It has been a tough journey, even though i have only reached html and css. Hope i will be as skilled as you.

  0
• 

  KingKrysiuk•50

  @KingKrysiukPosted almost 2 years ago

  add background color not only for a div, try this: body{ margin: 0px; background-color: hsl(212, 45%, 89%); }

  Marked as helpful

  0

  ---

  

  Nevin Siby•50

  @Nevin-SibyPosted almost 2 years ago

  @KingKrysiuk Thank you for the suggestion. I will implement it as soon as possible.

  0