QR-code

Community feedback

• 

  romila•3,570

  @romila2003Posted about 2 years ago

  Hi Veronica,

  Welcome to the frontend mentor community and congratulations 🎉 for completing this challenge, it was a great attempt. The card looks great however there are some issues I want to address.

  1. For accessibility purposes, it would be best practice to wrap your main code within the main tag which would ensure that your content is wrapped within the correct landmarks e.g. <main class="container"></main>
  2. It is important to add the alt attribute within the img tag e.g. <img class="img" alt="">
  3. I would suggest to give the body the flexbox property and give it the height of 100vh e.g.

  body {
    display: flex;
    align-items: center;
    justify-content: center;
    min-height: 100vh;
    background-color: var(--neutral-color-100);
  }
  

  Overall, great attempt and wish you the best for your future projects so keep coding 👍.

  Marked as helpful

  0

  ---

  

  Veronica Ulrikkeholm•40

  @veronisabPosted about 2 years ago

  @romila2003

  Hi! Thank you so much for your feedback, I really appreciate it!

  I wasn't aware that you are able to add a class to <main>, that is really a great help to know.

  1