qr-code

Community feedback

• 

  Faris Thibani•220

  @Faris-ThibaniPosted about 2 years ago

  Hi Alaa,

  Congratulations and well done on completing the project.

  You can improve the code with the following:

  1. Use semantic tags instead of div. The div is a generic element. Semantic tags improve code readability, accessibility, and overall structure.. here is a source to learn more: https://www.freecodecamp.org/news/semantic-html5-elements/

  2. You can organize the project in folders The files are all scattered and it would be more organized to have images in an images folder, CSS in a CSS folder, etc.

  3. Add some modularity to the code.. so that instead of having to repeat the same code in separate tags, you can create a utility class which in turn can be used to keep the file clean and easy to read. For example, if you happen to use a certain rule more than once like margin: 10px; then you can create a class selector called margin10 which will take the margin: 10px; rule and then use that class across the HTM..

  Hope this helps.. this has been a highlight of my own studying and practicing.

  Regards,

  Marked as helpful

  1