QR_code 2nd attempt

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 1 year ago

  Hi 04leslie.

  Congratulations for taking another attempt on this challenge and completing it. It's also great to hear that you have managed to fix the centering issue. Well done . Other things that you should look at , are as follows:

  • a site should consist of landmark elements - Landmarks can be used by assistive technology to quickly identify and navigate to large sections of the document. Some of the landmark elements include main, header and footer . In this challenge, I would expect to have the main element. According to MDN, the main element is described as: * The main content area consists of content that is directly related to or expands upon the central topic of a document, or the central functionality of an application.* You can use/change the div with the class of container into your main element.
  • image alt values are very important, if the image is just a decorative image, the value should be an empty string other than that the value should be about the message in the image. That will help assistive technology users and when the image fails to load.
  • class names such as b and d are not encouraged , you can look at the BEM naming system for inspiration. Class names can be related to what the styles being applied does to the element.
  • a site should have a heading element, I would expect one in this project.
  • font sizes should not be written as px values , the following article will give you the reasons Why font-size must NEVER be in pixels
  • research about any of the Modern CSS reset stylesheets, one mostly used one is by Andy Bell

  0