Qr-Challenge-Flexbox-Responsive

Community feedback

• 

  P

  Øystein Håberg•10,390

  @Islandstone89Posted 8 months ago

  HTML:

  • Always add an alt attribute on images! Decorative images should have empty alt text:alt="". This image, however, has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(frontendmentor.io).

  • Do not use <br> to force text onto a new line. The text should flow naturally, and all styling, including space between elements, should be done in the CSS.

  • Use <p> for the footer text.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • To center the card horizontally and vertically, with some space between the card and the footer, use Flexbox on the body:

  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  min-height: 100svh;
  gap: 2rem;
  

  • Remove all properties on main, they are not needed.

  • Remove the width and height on the image.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • Do the same as above with font-family.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container.

  Marked as helpful

  0
• 

  Oppqwjk•60

  @OppqwjkPosted 8 months ago

  Damn bro I actually learned stuff from your comment, ty dude you answered a lot of my questions :D. I'm young and its a little bit hard to underestand everything, but slowly I get it.

  1
• 

  Oppqwjk•60

  @OppqwjkPosted 8 months ago

  Thank you brother, Imma keep learning!

  1