Submitted over 1 year ago

QR-challenge

kingacygan•10

@kingacygan

Preview site View code

This is a solution for...QR code component

HTML
CSS

1newbie

Design comparison

SolutionDesign

Community feedback

Shaxboz•1,230

@shakhboz-shukhratPosted over 1 year ago

Hello there👋! Congratulations on completing this challenge!

The code looks good and there are no obvious issues. However, here are a few suggestions to consider:

Use consistent indentation for better readability.
Use double quotes consistently for HTML attributes.
Add a doctype declaration at the beginning of the HTML document.
Consider adding a language attribute to the HTML element.

With these suggestions, the updated code would look like this:

<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="icon" type="image/png" sizes="32x32" href="./images/favicon-32x32.png">
<title>Frontend Mentor | QR code component</title>
<link rel="preconnect" href="https://fonts.googleapis.com">
    <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
    <link href="https://fonts.googleapis.com/css2?family=Outfit:wght@400;700&display=swap" rel="stylesheet">
<link href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css\" rel="stylesheet" integrity="sha384-KK94CHFLLe+nY2dmCWGMq91rCGa5gtU4mk92HdvYe+M/SXH301p5ILy+dN9+nJOZ" crossorigin="anonymous">
<link rel="stylesheet" href="css/style.css">
  </head>
  <body>
<div class="container position-relative d-flex justify-content-center">
      <div class="row">
        <div class="col">
          <img class="img-fluid" src="images/image-qr-code.png" alt="Responsive image">
          <h1>Improve your front-end skills by building projects</h1>
          <h2>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</h2>
        </div>
      </div>
    </div>
<div class="attribution">
      Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="#">Kinga</a>.
    </div>
  </body>
</html>

Anyway, your solution is great. Hope you will find this helpful. Happy coding!

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord