@MelvinAguilar
Posted
Hi @ShahbaazX786 ๐, good job for completing this challenge!
Here are some suggestions to improve your code:
- Use
max-width: 300px
toarticle
selector instead ofwidth: 300px;
. - Use
margin: 0.625rem
ormargin: 10px
in thearticle
selector so that it has some space when viewed on mobile devices. - Use
min-height: 100vh
tobody
instead of height. - Don't worry so much if your design will overflow when reaching 75px or less, it's pushing the limits of responsiveness.
- You could use more the <p> tag, the <p> element is paragraph level content, usually text:
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
- Add a
<h1>
tag in your solution, The<h1>
element is the main heading in a web page. There should only be one<h1>
tag per page, and always avoid skipping heading levels; always start from<h1>
, followed by<h2>
and so on up to<h6>
(<h1>,<h2>,...,<h6>). The HTML Section Heading elements (Reference)
Solution:
<h1>Improve your front-end skills by building projects</h1>
I hope those tips will help you.
Good Job and happy coding !
Marked as helpful
@ShahbaazX786
Posted
@MelvinAguilar Thx for the super helpful suggestions, There is so much to learn in css ๐ .