Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-Card-Component using Flexbox.

@ShahbaazX786

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


It was rather easy but i still feel there is major room for improvement in this. recreating a replica is easy but making it exactly same is kinda tough.

Questions: Is there any way to make the content(text,imgs etc) in the div or card component make smaller according to the width of the screen. I tried using width:100% or width:100vw but it was not good enough and was overflowing out of the component when i try to decrease the screen size beyond 200px.

Community feedback

@MelvinAguilar

Posted

Hi @ShahbaazX786 ๐Ÿ‘‹, good job for completing this challenge!

Here are some suggestions to improve your code:

  • Use max-width: 300px to article selector instead of width: 300px;.
  • Use margin: 0.625rem or margin: 10px in the article selector so that it has some space when viewed on mobile devices.
  • Use min-height: 100vh to body instead of height.
  • Don't worry so much if your design will overflow when reaching 75px or less, it's pushing the limits of responsiveness.
  • You could use more the <p> tag, the <p> element is paragraph level content, usually text:
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
  • Add a <h1> tag in your solution, The <h1> element is the main heading in a web page. There should only be one <h1> tag per page, and always avoid skipping heading levels; always start from <h1>, followed by <h2> and so on up to <h6> (<h1>,<h2>,...,<h6>). The HTML Section Heading elements (Reference)

Solution:

<h1>Improve your front-end skills by building projects</h1>

I hope those tips will help you.

Good Job and happy coding !

Marked as helpful

1

@ShahbaazX786

Posted

@MelvinAguilar Thx for the super helpful suggestions, There is so much to learn in css ๐Ÿ˜….

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord