qr-card-component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="qr-container"> with the main tag to fix the accessibility issue. click here for more on web-accessibility and semantic html

  To center .qr-card on the page using flexbox, replace the height in .qr-container with min-height: 100vh.

  Give h1 and p the same font-size of 15px which is 0.9375rem and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Reduce the max-width of .qr-card for it to be equivalent to the width of the design. max-width:320px which is 20rem.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  Amr mohamed•370

  @AmrAbdelgwaadPosted over 1 year ago

  @Hassiai your comment is appreciated I will make these changes later but how do you know that the width of the card is 320px

  0