Skip to content
Submitted about 2 years ago

Qr-Card

KeerthiVasan-N•350
@KeerthiVasan-N
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I am looking for constructive criticism Thank you

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello @KeerthiVasan-N, Congratulations on completing this challenge!

    Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

    Your solution is great and the code is working, but the HTML structure can be reduced by removing unnecessary divs, all you need is a single <main> or <div> to keep all the content inside, and nothing more. The ideal structure is the div and only the image, heading, and paragraph.

    Here’s one example to show can be cleaner this HTML structure:

    <body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    To reduce the CSS you can use the direct selector for each element instead of using class this way you have a code even cleaner, for example, you can select everything using the direct selector for (img, h1, and p, main).

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    1
  • Divine Obeten•2,415
    @Deevyn9Posted about 2 years ago

    Hi, congrats on completing this project, your solution looks really good, However you'll need to center the container you can do this by: Giving the body a min-height of 100vh, a width of 100vw then you give it a display: grid; and then you place-items: center; to center the container.

    I hope this solves your problem and you find it helpful.

    Happy coding!

    Marked as helpful
    0
  • KeerthiVasan-N•350
    @KeerthiVasan-NPosted about 2 years ago

    Thankyou for your feedback Sir!

    0
  • KeerthiVasan-N•350
    @KeerthiVasan-NPosted about 2 years ago

    Thank you Sir And I'll try to implement it

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord