Qr using basic CSS and HTML

Community feedback

• 

  Car•140

  @Lukas3162000Posted about 2 months ago

  Hey Ricarddo96, Unfortunatly im a total beginner myself, so i can only feedback you on the size of the h1 which looks a bit too small and the left and right paddings on the content-part of your card.

  The Shadow looks a bit too dark aswell, but these are only small css tweeks. I really like that your card is responsive and the border-radius goes from rounded to sharp the smaller the card gets - great work ! :)

  hope that helped a bit atleast :D

  kind regards, Lukas

  Marked as helpful

  1

  ---

  

  P

  ricarddo96•20

  @ricarddo96Posted about 2 months ago

  @Lukas3162000 you helped a lot, thank you! Im a begginer too but im excited to learn more!

  1
• 

  P

  Tom Winskell•130

  @tomwinskellPosted about 2 months ago

  Here's some suggestions that I though might help.

  • One of the biggest issues I can see if the alignment of your component. It should be centred on the screen. It's worth learning how your can create layouts using flexbox. Flexbox makes it really easy to center something on the screen. Check out https://css-tricks.com/snippets/css/a-guide-to-flexbox/.
  • Nice reset with the use of * in your css. There are also pre-prepared CSS resets which you can use https://meyerweb.com/eric/tools/css/reset/.
  • Organizing your CSS into sections with comments as headers can help. This project is small but as your CSS files getter bigger and longer, sections and comments can really help. I find it has been useful to practise this with smaller projects first. For example:

  // Font-styles
  h1{
      font-size: 21px;
  }
  
  p{
      font-size: 15px;
      color: hsl(216, 15%, 48%);
  }
  

  0