QR solution (css+html)

Community feedback

• 

  Hoshiko•180

  @oliwiakrammPosted almost 2 years ago

  This comment was deleted 10 months ago

  1

  ---

  

  taioofh•10

  @taioofhPosted almost 2 years ago

  @oliwiakramm thank you for your advice , I will follow your tips

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="mainCard"> with main tag, <h3> with<h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  There is no need to style .content and .image

  To center .maincard on the page using flexbox, add min-height:100vh; display: flex; align-items: center: justify-content: center; to body.

  To center .mainCard on the page using flexbox:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  For a responsive content which wont require media query for this challenge, replace the width in .mainCard with max-width and reduce it value for it to be equivalent to the width of the design. max-width:320px. Replace the height in .card with a padding value for all the sides, this will prevent the content from overflowing on smaller screens and its a responsive replacement. padding: 15px.

  Give the img a max-width of 100% and a border-radius , the rest are not needed.

  Give .info a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  taioofh•10

  @taioofhPosted almost 2 years ago

  @Hassiai cool, I didn't know all this, really nice of you to give me your opinions and I appreciate it

  0