QR solution

Community feedback

• 

  P

  Øystein Håberg•12,900

  @Islandstone89Posted 11 days ago

  Hi Manuel, good job.

  Here are a few words of advice:

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" content. Change .container to a <main>.

  • The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • Headings should always be in order, so you never start with a <h3>. I would change it to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  • Do not use <br> to force text onto a new line. The text should flow naturally, and all styling, including space between elements, should be done in the CSS.

  CSS:

  • Make a habit of including a modern CSS Reset at the top of the stylesheet.

  • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

  • Move font-family to body.

  • Move the styles on .container to the body.

  • On the body, remove margin: 0 auto, it is not needed.

  • Descendant selectors like .card p increase specificity, making the styles harder to override. Instead, give elements a class, and use that as the selector.

  • It's not recommended to use % for properties such as margin, padding and border-radius. Use px, em or rem.

  • Remove the width on the card.

  • max-width on the card should be in rem. Around 20rem works well.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • To create the space between the image and the edge of the card, set padding on all 4 sides of the card: padding: 16px;.

  • Good job having max-width: 100% on the image! Applying display: block and height: auto is also common. Remove the padding, it is not needed.

  0