Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Gowsala, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
main
tag and wrap the card for improve the Accessibility - remove
width
from.container
class because isn't necessary - use
min-height: 100vh
insteadheight
to.container
class - instead of using
px
use relative units of measurement likerem
-> read here
Overall you did well 😁
Hope this help and happy coding!
Marked as helpful0@GowsalayadeviPosted over 2 years ago@denielden Thanks Deniel. That was really helpful :)
1 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord