Submitted almost 2 years ago

QR Scan using html divs

#accessibility

Issiecodes•20

@issiecodes

Preview site View code

This is a solution for...QR code component

HTML
CSS

1newbie

Design comparison

SolutionDesign

Solution retrospective

the area of styling the image

Community feedback

Abdul Khaliq 🚀•72,460
@0xabdulkhaliqPosted almost 2 years ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have some recommendations regarding your code that I believe will be of great interest to you.

ESSENTIALS ♻️:

And, This solution has also generated accessibility error reports due to lack of lang attribute inside of html element

<html> element must have a lang attribute with valid value, so fix it by updating like this <html lang="en">

HTML 🏷️:

This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage

So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

IMAGES 📸:

Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. alt="QR code to frontendmentor.io"

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!
Marked as helpful
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord