qr scan component

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi Godwin, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  1.You've done the design for the wrong image, when you download the starter files the folder comes with 3 files (preview card, desktop and mobile) you've created the solution based on the preview and you should consider only the mobile + desktop images.Remove the background-color from the container and add it to the body to make sure this color background will display it full screen.

  2.Replace the <h5> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.

  3.Use relative units like rem or em instead of px to have a better performance when your page content resizes on different screens and devices. REM and EM does not just apply to font size, but all sizes as well. To save your time you can code your whole page using px and then in the end use a VsCode plugin called px to rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0
• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  Hello, Godwin! 👋

  It looks like you were using the design-preview.jpg as the guide to design the website. The design-preview.jpg is used as a preview image for the README.md file. The other design files are what to use as a reference when building the project.

  Some suggestions:

  • Headings must be in a logical order (start from h1 to h6). Users of assistive technology can use heading tags to navigate the website. If headings are not in a logical order, those users can get confused.
  • I recommend reading the "How-to: Accessible heading structure - The A11Y Project" article to learn how to use headings correctly.
  • The alternative for the QR code needs improvement. Tell the users about the QR code. In this case, it will navigate the users to https://www.frontendmentor.io/. So, the alternative text should be "QR code to frontendmentor.io".
  • For your information, there's no need for media queries to make the site responsive. For your inspiration, you can take a look at my solution.

  That's it! I hope this helps! Happy coding!

  Marked as helpful

  0