Skip to content
Submitted about 2 years ago

qr page with flex css

sujeong•40
@sujeong054
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

someone told me that I need to use semantic tags more often. So I use the main tag before the div. the container then the result was not the same as the result I have to make. it was in the middle but leaning to the left. so I delete the main tag then it could be the same as the result like the result. why is that happening? I'm a beginner so I need someone to explain it to me.

Community feedback

  • Adriano•38,410
    @AdrianoEscarabotePosted about 2 years ago

    Hi sujeong, how are you?

    I really liked the result of your project, but I have some tips that I think you will enjoy:

    To improve the accessibility of the project you could have put an h1. Every page must contain a level 1 header, for people who use screen readers, identity what the main title is and follow the sequence h1-h5, to solve change the h2 by h1

    images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty alt="" and add aria-hidden="true" attributes to make all the assistive technologies of the Web, as screen reader. Learn the differences between decorative/meaningless images vs important content.

    do this:

    <img src="images/image-qr-code.png" alt="QR code">

    The rest is great!

    I hope it helps... 👍

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord