qr page with css flex

Community feedback

• 

  Arthur Roberts•410

  @arfarobsPosted over 2 years ago

  Hey Harel. I have a few suggestions to help you improve your solutions.

  1. The image doesn't display properly. I noticed that there is an error in the <img> src attribute. Your code: <img src="/images/image-qr-code.png" class="card__img" alt=""> Corrected version: <img src="./images/image-qr-code.png" class="card__img" alt=""> The first / needs a full stop in-front of it.

  2. To avoid the errors in the report, there are two things that you can do.

  • Wrap your HTML in a <main> element.
  • Instead of using an <h3> element use an <h1> element. Headings are supposed to follow a kind of hierarchy system. If you only have one heading element, it should be an <h1>. Every page should only have one <h1> element. Then after that use <h2> then <h3> <h4> etc. depending on the importance of the heading.

  Marked as helpful

  1

  ---

  

  Harel Kaufman•50

  @Harelk1015Posted over 2 years ago

  @arfarobs Ooo wow i dident expect someone to replay, you really surprised me. Thanks for the correction ! I really couldnt understand why the qr doesnt work. I respect you thanks !

  1

  

  Arthur Roberts•410

  @arfarobsPosted over 2 years ago

  @Harelk1015 No problem, Harel. Happy coding.

  1