Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR page on a web page

@cas1092

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

i thik i should make a mockup first instead on going directly to the coding part

What challenges did you encounter, and how did you overcome them?

probably the most challenging part was jump from tutorials and documentation to the real coding, the fact that i didn't had a plan made it harder.

What specific areas of your project would you like help with?

i don't have so much experience with the design of things, maybe that's why i find the css more problematic, not so much for the languaje but for the components.

Community feedback

Boris 2,870

@mkboris

Posted

Hi @cas1092 great job completing your first challenge, here are a few things to review

  • To properly center the card, use Flexbox on the body rather than transform and margins on the container. Add this to the body and remove the transform and margin properties from the .container
    min-height: 100vh;
    display: flex;
    align-items: center;
    justify-content: center;
    flex-direction: column;
    gap: 1rem;
  • Avoid setting fixed widths on elements, as this can create problems with responsiveness and content fit. Instead, let the content and padding determine the element’s size. If necessary, use max-width and prefer relative units like rem for better adaptability. Update the .container width to use max-width and should be defined in rem.
  • Change the img width to max-width: 100%; This as well as other reset styles is included in CSS reset you should use at the start of the styles in every project. This will help reset a list of default browser styles.
  • Your image is missing an alt attribute like so alt="Qr Code to Frontendmentor.io"
  • All content should be wrapped within landmarks. Wrap a footer tag around the .attribution
  • It's best practice linking Google fonts directly in the HTML head section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times.
0

@cas1092

Posted

@mkboris Thanks! i knew there was a better than modify the margins, i was playing with numbers that made sense for my solution.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord