QR Newbie Challenge using basic HTML and CSS

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @jesuswrivas 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

  I have some suggestions you might consider to improve your code:

  • Use the <main> tag to wrap all the main content in your solution instead of using <div class="border1">.

  • Try to use more descriptive names for your classes. I suggest you learn the BEM naming convention standard for CSS class names because increases the readability of front-end code and provides a modular structure. For example, the classes "border1" and "qrtext2" do not say what they are.

  • Setting a defined height for the card component is not recommended. In addition, simply setting paragraph heights will lead to problems. The content should define the component height, otherwise, it will not be allowed to extend beyond your specifications. Alternatively, you can use min-height for the component.

  • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.

  • The container isn't centered correctly. You can use flexbox or grid layout to center elements. You can read more about centering in CSS here.

  Above all, the project is done well👏. I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  Marked as helpful

  1

  ---

  

  Jesus•20

  @jesuswrivasPosted about 2 years ago

  Hi @MelvinAguilar, thank you for your time!

  This was a beautiful and well explained feedback. These tips will definitely help me! Thank you for your time and kindness.

  1

  

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  @jesuswrivas You’re welcome! 👍

  0