Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Request path contains unescaped characters
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR

Serโ€ข 250

@SinthMite

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

rayaโ€ข 2,850

@rayaatta

Posted

Hello ๐Ÿ‘‹sinth, congratulations on completing your first FED challenge ๐ŸŽ‰

I have some suggestions you might find interesting.

1 Every html document should have a main tag that encloses the main page contents change <div class="card"> To <main class="card"> This will change nothing visually but it makes all the difference. You can learn more about the main tag in this article

2 I noticed that you used <div id="bold"> for your heading. It is better if you replace it with <h1> Here's a quick guide on how to use them:

The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on. You can then style them in you css.

Unlike what most people think, it's not just about the size and weight of the text It is about maintaining a clear and consistent hierarchy through out the document

3 Make your html more semantic. divs do not carry any semantic value. They are used solely for decorations. You should replace <div id="passage"> with <p>.

4 You can find out more about semantic Html and more in this article๐Ÿ“‘.

I hope this helps ๐Ÿ™ƒ

Otherwise nice solution ๐Ÿ‘

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord