Brendan• 1,120
@OneManBanned
Posted
Hi Randall a nice looking solution.
I only have a few suggestions.
-
You should change the <h3> to a <h1>. All pages need a <h1> heading element. The usage notes section on the mdn headings page explains why. Here is the link
-
I would also change the
.main-qrdiv into a <main> element. The <main> HTML element represents the dominant content of the <body> of a document. -
In your css I would suggest you avoid adding fixed
widthandheightdeclarations and usemin-width-max-widthinstead. This can make your page a lot more flexible to different screen sizes. Same goes for using pixels. It would be better to use relative units like % and rem.
I hope you find that helpful.
Good work.
0
