QR Connect: Frontend Mastery

Community feedback

• 

  Danijel Adrinek•420

  @DanijelAdrinekPosted 8 months ago

  Hey Patrycja, I liked your project and decided to take a look at it for a bit, and I found some things I think you can improve on.

  1. You forgot to remove > that is found under the card, moving it up from the middle

  2. The text class names are for sure over-complicated for a project this small, I get where you're going with it, but its not necessary to have these long naming conventions in this project, that would be great if you were programming a shopify theme tho, but here, its okay to just name the first class card, and if you think other elements will be added, you can add in css .qr-component .title {/* CSS code */}

  3. You should add the text together in one div that should be called text-container, it makes it easier to manipulate the text like that, especially if you're good at using flexbox, and you wont need to assign separate classes to title and paragraph, you can use .card .text-container > h1 {/* CSS code */} or .card .text-container > p {/* CSS code */}

     to select these elements.

  4. Use CSS variables, they are a powerful tool to help make your code more readable and easy to manipulate

  5. The solution you provide should match the design, it is a bit complicated to understand how to do that for the first time, so if you want, I have written my own blog post on solving this challenge, where I explain how to make pixel-perfect solutions to any challenge you might be facing in the future, using this one as an example. here is the link if you want to check it out:

  https://dev.to/danijeladrinek/frontend-mentor-qr-code-challenge-4g9h

  This is still a great project, one of the better ones I have seen, but I hope these tips help you become a better web developer, and help you on your journey towards getting this amazing job! 🚀

  if you have any more questions feel free to let me know, have an amazing day, and happy coding :)

  0

  ---

  

  David•80

  @David-dawnPosted 8 months ago

  @Patrycja-dz thank you for giving me feedback on my Qr-code-component You did a good job also on this challenge... Keep it up bro

  0