QR-Component with scss

Community feedback

• 

  Daniel Alejandro Cano Cardona•110

  @DacardonacPosted 3 months ago

  Hello Strach22, I hope you are doing very well, congratulations on your project and the solution you have delivered. In this comment, I want to give you feedback in the form of constructive criticism in which I will provide you with some recommendations and materials to improve your project in certain aspects.

  • Try to keep your project with only language, in this environment, it is better and is a good practice to keep everything in English, in this case, you have multiple files CSS, and SCSS named in Spanish. ‎
  • Try to use the Metadata in HTML because this data improves your SEO and makes your project more accessible in the browser, in this link you can read about that. Metadata in HTML ‎
  • Another point is to try to use the Methodology BEM, this methodology helps you to improve the code structure and to relate the classes. Here I leave you a link to read about and improve this aspect of your project. Methodology BEM ‎
  • In this project I can see the file css.map, in projects try not to expose the source map of the security application. ‎
  • When you work with Sass try to have all styles modularized and in components so that way you will have more order in your project, in this link you can read about that. Sass documentation

  0