Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-Component with scss

strach22 30

@strach22

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am practicing and learning, it took me like 2 hours

What challenges did you encounter, and how did you overcome them?

Remembering name tags

What specific areas of your project would you like help with?

Any comments can be useful

Community feedback

@Dacardonac

Posted

Hello Strach22, I hope you are doing very well, congratulations on your project and the solution you have delivered. In this comment, I want to give you feedback in the form of constructive criticism in which I will provide you with some recommendations and materials to improve your project in certain aspects.

  • Try to keep your project with only language, in this environment, it is better and is a good practice to keep everything in English, in this case, you have multiple files CSS, and SCSS named in Spanish. ‎
  • Try to use the Metadata in HTML because this data improves your SEO and makes your project more accessible in the browser, in this link you can read about that. Metadata in HTML
  • Another point is to try to use the Methodology BEM, this methodology helps you to improve the code structure and to relate the classes. Here I leave you a link to read about and improve this aspect of your project. Methodology BEM
  • In this project I can see the file css.map, in projects try not to expose the source map of the security application. ‎
  • When you work with Sass try to have all styles modularized and in components so that way you will have more order in your project, in this link you can read about that. Sass documentation
0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord