@rayaatta
Posted
Hello Ayua Michael👋, congratulations on completing your first FED challenge 🎉
I have some suggestions you might find useful.
1
I noticed font-size: 15px; in your code.
You should never use pixels when setting font related properties.
Setting font sizes in pixels causes accessibility problems with people who adjusted their default font sizes on their computers.
The best units for setting font size are relative units such as rem and em which can adjust with the user preferences. Checkout this article why font size should never be in pixels
2
The qr code's alt attribute should not just have info that it is a qr code rather it should state where the qr leads i.e
alt="qr code leading to frontendmentor.io
I hope this helps 🙃
Otherwise your solution is neat👍
Happy coding ✌️
Marked as helpful
@scotttabor
Posted
@rayaatta Thank you for the tips!!
