Skip to content
Submitted 10 months ago

QR Component with HTML and vanilla CSS

scotttabor•110
@scotttabor
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

First upload, self taught developer and I would love to have any advice or tips on things I should change or best practices that I should be implementing.

Community feedback

  • raya•2,850
    @rayaattaPosted 10 months ago

    Hello Ayua Michael👋, congratulations on completing your first FED challenge 🎉

    I have some suggestions you might find useful.

    1 I noticed font-size: 15px; in your code. You should never use pixels when setting font related properties. Setting font sizes in pixels causes accessibility problems with people who adjusted their default font sizes on their computers.

    The best units for setting font size are relative units such as rem and em which can adjust with the user preferences. Checkout this article why font size should never be in pixels

    2 The qr code's alt attribute should not just have info that it is a qr code rather it should state where the qr leads i.e alt="qr code leading to frontendmentor.io

    I hope this helps 🙃

    Otherwise your solution is neat👍

    Happy coding ✌️

    Marked as helpful
    0
    scotttabor•110
    @scotttaborPosted 10 months ago

    @rayaatta Thank you for the tips!!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord