Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-COMPONENT WITH HTML AND CSS

P

@laxmikishore13

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What specific areas of your project would you like help with?

I am not very good at css, i want to know if i followed correct/ good ways to get the solution.

I want to help in index.html page, whether the code structure is good.

Community feedback

@Dsimpson91

Posted

Hi Kishore,

This is looks great don't be so hard on yourself when it comes to css it sucks lol. No seriously there's multiple ways to do things using css. For an example i used flexbox your css looks good to me and it's responsive. I'll give you a tip to help keep it cleaner instead of doing this

.qr-section-info { margin-top: 24px; padding: 0px 16px 0px 16px; }

.qr-section-info h2 { color: rgb(31, 49, 79); margin: 0 16px 16px 16px; font-size: 22px; font-weight: 700; line-height: 1.2; }

.qr-section-info p { color: rgb(104, 119, 141); font-size: 15px; line-height: 1.4; font-weight: 400; margin: 0 16px 16px; }

add everything under your selector like this

.qr-section-info { margin-top: 24px; padding: 0px 16px 0px 16px; p { color: rgb(104, 119, 141); font-size: 15px; line-height: 1.4; font-weight: 400; margin: 0 16px 16px; } h2 { color: rgb(31, 49, 79); margin: 0 16px 16px 16px; font-size: 22px; font-weight: 700; line-height: 1.2; } }

this will make things easier to maintain once you start working on larger projects my last comment is just practice flexbox, css grid, and sass it will make things easier. Great job !!!!!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord