QR component with flexbox

Community feedback

• 

  Fabianthorsen•170

  @FabianthorsenPosted almost 2 years ago

  Hey, great solution! A couple of things I would refactor if I was doing it myself is to use the cascading to the fullest. This is a trivial challenge, but setting the font-family on the overall html page I feel would be make more semantic sense, and rather set the font-family to the individual object if you are using different fonts for titles and so on. Also in regards to text styling, you could set the text-align property on the higher-level element like the container instead. Lastly I would consider giving the example a background just for the sake of accessibility with better contrasts!

  Anyways, great submission :D

  Marked as helpful

  0