Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR component with flexbox

Dev JP 140

@JpJonker

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@Fabianthorsen

Posted

Hey, great solution! A couple of things I would refactor if I was doing it myself is to use the cascading to the fullest. This is a trivial challenge, but setting the font-family on the overall html page I feel would be make more semantic sense, and rather set the font-family to the individual object if you are using different fonts for titles and so on. Also in regards to text styling, you could set the text-align property on the higher-level element like the container instead. Lastly I would consider giving the example a background just for the sake of accessibility with better contrasts!

Anyways, great submission :D

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord