QR Component

Community feedback

• 

  Amal Karim ✅•1,290

  @amalkarimPosted almost 2 years ago

  Hi Nemanja 👋

  I don't wanna say about right or wrong, because web page styling is like a preference. Some people prefer to do this, the other want to do that, and so on.

  I have a few personal suggestions for your solution. In your .content-wrap, there's this style: margin-top: 140px;. If you want to position it at the center of the page, it wouldn't work on every browser, because not all browser have the same height. Remove that margin-top, and change .container style to this:

  .container {
      display: flex;
      align-items: center;
      justify-content: center;
      min-height: 100vh;
  }
  

  Also, remove height: 570px; from .content-wrap because it will make some parts of the text placed outside the box.

  Hope this helps. Happy coding!

  Marked as helpful

  1

  ---

  

  Nemanja•130

  @Dayne2xPosted almost 2 years ago

  @amalkarim Thanks for the feedback, that type of positioning is what I had issues with, so I opted for this type of solution. I realize it's not good practice to do so from what I've gathered, so I will try your solution, and try to apply what you've told me in future projects.

  0