QR Component using vanilla html/css w/ flex

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • let me explain, How you can easily center the component.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  body {
    grid-template-columns: 1fr;
    grid-template-rows: 1fr auto;
    grid-template-areas: "content", "footer";
  }
  
  .card {
    grid-area: "content";
    margin-top: 16vh;
    margin-left: auto;
    margin-right: auto
  }
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  nattyrice•20

  @nattyricePosted over 1 year ago

  @0xAbdulKhalid

  Thanks for the help! I had actually just got done working out how to get the flex to work on my own. Yeah, I had a lot of things I'd tried while I was throwing things at the wall to see what stuck. As you'd noticed, some of it was getting in my way. I think I like your grid/place-items recommendation more.

  0
• 

  Edson Ruiz•160

  @xedsonruizxPosted over 1 year ago

  Hi i have some corrections for you, I am not an English speaker so If you dont understand something send me an email to [email protected], I will try to help you.

  • body size 100 just add to your css code

  body { height: 100%; }

  How to make body and html 100 heght

  • Center vertical card

  there is some ways to center a card in the middle of the page this is what I used code example and playground

  with this you can delete the top margin top from media query. I hope this will help you.

  Marked as helpful

  1

  ---

  

  nattyrice•20

  @nattyricePosted over 1 year ago

  @xedsonruizx Thanks! I went with min-height: 100vh that your link recommended.

  0