QR Component using SCSS

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="card"> with the main tag and <h2> with <h1> to make the content/page accessible. click here for more on web-accessibility and semantic html

  Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  Give .qr-main a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1. Give p a margin-top or h1 a margin-bottom value for the space between the text.

  For a responsive content,

  • There is no need to give .card a max-height value, increase the padding value for all the sides padding:16px which is 1rem/em
  • Give the img a max-width of 100% and a border-radius value, the rest are not needed.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Dan McGrath•10

  @Dan-McGrathPosted over 1 year ago

  @Hassiai Thank you! This helped a lot. I was kind of thinking of this as a card on a page with other elements which is why I used those elements. Your response though made me realize that this could be a kind of pop-up page after a link is clicked so thank you for the insight.

  0
• 

  Shalom2935•420

  @Shalom2935Posted over 1 year ago

  100% didn't work because you gave your image a margin. Whatever this is a better way to make an image responsive.

  1. give the image a 100% width and DON'T SET ITS HEIGHT!!!
  2. give its container the wanted width and a height that adjust automatically (auto) in your case you should have something like this:

  .qr-img {
  width:100%;
  height:auto;
  }
  .qr-img img{
  width:100%;
  }
  

  Marked as helpful

  1

  ---

  

  Dan McGrath•10

  @Dan-McGrathPosted over 1 year ago

  @Shalom2935 Awesome, thank you! I figured it was something I hard coded but I couldn't find the error.

  0
• 

  Josh•1,110

  @josh76543210Posted over 1 year ago

  Hi @Dan-McGrath,

  Removing the margin: 0.4rem; on the image should do the trick. When the image has width: 100%;, the margin is not needed. The width: 97%; was working because the margin was offsetting it.

  Hope this helps.

  1

  ---

  

  Dan McGrath•10

  @Dan-McGrathPosted over 1 year ago

  @josh76543210 Thank you! That makes since.

  0