QR component using React

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Let me explain, How you can easily center the component for better layout without usage of absolute positioning.

  ---

  • We don't need to use absolute to center the component both horizontally & vertically. Because using absolute will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component

  body {
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .App {
  position: absolute;
  left: 50%;
  top: 50%;
  -webkit-transform: translate(-50%,-50%);
  transform: translate(-50%,-50%);
  }
  

  ---

  • Now your component has been properly centered.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Andrea Iriarte•130

  @andrea-iriartePosted over 1 year ago

  @0xAbdulKhalid

  Thanks, Abdul, for the resources. I'll look into them and start using flex / grid for centering soon!

  0
• 

  Rebecca Padgett•1,840

  @bccpadgePosted over 1 year ago

  Hello @andrea-iriarte. Congratulations on completing this challenge! 🎉

  I am not familiar with React but your solution looks great and have a few tips to improve your solution.

  I see you are not using HTML SEMANTIC TAGS in your code. It is very important to do so for accessibility reasons. This W3schools article explain why and how to use them properly. HTML Semantic Tags

  Wrap your content using <main> tag and for your attribution information you can use <footer> tag for accessibility reasons.

  CSS

  You should always use rem not pixels for font size. Rem vs Pixels

  Hope this helps you!

  Marked as helpful

  1

  ---

  

  Andrea Iriarte•130

  @andrea-iriartePosted over 1 year ago

  @bccpadge

  Hi Rebecca,

  Thank you for your comments! I will start using HTML semantic tags more often. I typically use rem units, but decided to stick to pixels here since the component is very simple and static, rather than responsive. I agree, though, that in general, rem is much better.

  Thanks again, Andrea

  0